From 8e75e9d763a120b5edacd313420605dc6450e1e7 Mon Sep 17 00:00:00 2001 From: Cubarco Date: Fri, 11 Nov 2022 14:20:19 +0800 Subject: [PATCH] Fix sockopt.TcpKeepAliveInterval The Keep-Alive configs may be overridden with golang default settings when `tcpKeepAliveInterval` is set without `tcpKeepAliveIdle`. --- transport/internet/system_dialer.go | 2 +- transport/internet/system_listener.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/transport/internet/system_dialer.go b/transport/internet/system_dialer.go index b809618c..93cf404e 100644 --- a/transport/internet/system_dialer.go +++ b/transport/internet/system_dialer.go @@ -70,7 +70,7 @@ func (d *DefaultSystemDialer) Dial(ctx context.Context, src net.Address, dest ne }, nil } goStdKeepAlive := time.Duration(0) - if sockopt != nil && sockopt.TcpKeepAliveIdle != 0 { + if sockopt != nil && (sockopt.TcpKeepAliveInterval != 0 || sockopt.TcpKeepAliveIdle != 0) { goStdKeepAlive = time.Duration(-1) } dialer := &net.Dialer{ diff --git a/transport/internet/system_listener.go b/transport/internet/system_listener.go index c4329c9e..04694383 100644 --- a/transport/internet/system_listener.go +++ b/transport/internet/system_listener.go @@ -51,7 +51,7 @@ func (dl *DefaultListener) Listen(ctx context.Context, addr net.Addr, sockopt *S network = addr.Network() address = addr.String() lc.Control = getControlFunc(ctx, sockopt, dl.controllers) - if sockopt != nil && sockopt.TcpKeepAliveIdle != 0 { + if sockopt != nil && (sockopt.TcpKeepAliveInterval != 0 || sockopt.TcpKeepAliveIdle != 0) { lc.KeepAlive = time.Duration(-1) } case *net.UnixAddr: